Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progress notification cancelable default is different than vscode #8421

Closed
DoroNahari opened this issue Aug 24, 2020 · 0 comments · Fixed by #8479
Closed

progress notification cancelable default is different than vscode #8421

DoroNahari opened this issue Aug 24, 2020 · 0 comments · Fixed by #8479
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility

Comments

@DoroNahari
Copy link
Contributor

Bug Description:

In the progress notification the default of the cancelable option in Theia is true and in vscode it's false.

Steps to Reproduce:

Run this extension on Theia and vscode without declaring cancelable. (remove this line)

See that on vscode there's no cancel button and in Theia there is.

Additional Information

  • Operating System: mac os
  • Theia Version: master
@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility labels Aug 24, 2020
@DoroNahari DoroNahari mentioned this issue Sep 8, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix progress notification issues DoroNahari/theia
2 participants
@akosyakov @DoroNahari