Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: 'findFiles' should search ignored files when exclude is 'null' #8451

Closed
vince-fugnitto opened this issue Sep 1, 2020 · 0 comments · Fixed by #8452
Closed

plugin: 'findFiles' should search ignored files when exclude is 'null' #8451

vince-fugnitto opened this issue Sep 1, 2020 · 0 comments · Fixed by #8452
Labels
vscode issues related to VSCode compatibility

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

Originally Reported: #8427.

The findFiles plugin API should search within ignored files when exclude: null according to vscode's documentation.
At the moment, searching with null yields no results when exclude is null (incompatibility with vscode).

image

Steps to Reproduce:

  1. use the vscode extension: vscode-find-files
    (the extension searches for all readme files and prints those within node_modules (gitignored))
  2. start the application
  3. execute the command echo files
  4. no results are found, while in vscode readme files are printed)
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant