Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calling extension activate() by other extension doesn't work. #8463

Closed
tomer-epstein opened this issue Sep 3, 2020 · 4 comments
Closed

calling extension activate() by other extension doesn't work. #8463

tomer-epstein opened this issue Sep 3, 2020 · 4 comments
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system 🤔 needs more info issues that require more info from the author

Comments

@tomer-epstein
Copy link
Contributor

Description
calling extension.activate() method from another extension doesn't activate the extension.

Reproduction Steps
tested with those vscode extensions - https://github.com/tomer-epstein/vscode-extension-activate.git

  1. Pack (create vsix) for https://github.com/tomer-epstein/vscode-extension-activate/tree/master/vscode-manager
  2. Pack (create vsix) for https://github.com/tomer-epstein/vscode-extension-activate/tree/master/vscode-contrib1
  3. execute 'extension.activateContributor' command.
@tomer-epstein
Copy link
Contributor Author

tomer-epstein commented Sep 3, 2020 •
edited
Loading

at --> https://github.com/tomer-epstein/vscode-extension-activate/blob/master/vscode-manager/src/extension.ts#L14

@akosyakov
Copy link
Member

Hi, could you provide what do you mean by does not work and fail? Are there any logs on backend or in browser?

@akosyakov akosyakov added 🤔 needs more info issues that require more info from the author bug bugs found in the application help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system labels Sep 3, 2020
@tomer-epstein
Copy link
Contributor Author

logs shows no errors. the vscode-contribtor activate func is not being caled.

@tomer-epstein tomer-epstein mentioned this issue Sep 22, 2020
Merged
1 task
@vince-fugnitto
Copy link
Member

Fixed by: #8542.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system 🤔 needs more info issues that require more info from the author
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @vince-fugnitto @tomer-epstein