Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scm: tree-search should highlight matched nodes #8581

Closed
vince-fugnitto opened this issue Oct 2, 2020 · 1 comment · Fixed by #8929
Closed

scm: tree-search should highlight matched nodes #8581

vince-fugnitto opened this issue Oct 2, 2020 · 1 comment · Fixed by #8929
Labels
help wanted issues meant to be picked up, require help scm issues related to the source control manager tree issues related to the tree (ex: tree widget)

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

The tree-search for scm should properly highlight matched nodes like in other areas (ex: explorer).
At the moment, nodes are not highlighted which is both confusing and inconsistent with the rest of the framework.

Steps to Reproduce:

  1. start the application, perform changes and open the scm view
  2. type to start the tree-search
  3. notice how no highlights are present
@vince-fugnitto vince-fugnitto added help wanted issues meant to be picked up, require help tree issues related to the tree (ex: tree widget) scm issues related to the source control manager labels Oct 2, 2020
@colin-grant-work
Copy link
Contributor

The problem here seems to be that TreeSearch relies on this to get the string to filter on:

(node: TreeNode) => this.labelProvider.getName(node);

But the SCM tree itself extracts the URI from a node before it asks the label provider for the name:

const name = this.labelProvider.getName(new URI(node.sourceUri));

I'll look into reconciling the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted issues meant to be picked up, require help scm issues related to the source control manager tree issues related to the tree (ex: tree widget)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants