Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal: add support for opening external terminal windows #8712

Closed
vince-fugnitto opened this issue Nov 5, 2020 · 1 comment · Fixed by #9186
Closed

terminal: add support for opening external terminal windows #8712

vince-fugnitto opened this issue Nov 5, 2020 · 1 comment · Fixed by #9186
Labels
electron issues related to the electron target enhancement issues that are enhancements to current functionality - nice to haves terminal issues related to the terminal

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Nov 5, 2020

Feature Description:

As an end-user, I'd like the possibility to open an external terminal through a new command and service similarly to vscode:

command: {
  id: OPEN_NATIVE_CONSOLE_COMMAND_ID,
  title: { value: nls.localize('globalConsoleAction', "Open New External Terminal"), original: 'Open New External Terminal' }
}

I believe the command would only make sense in an electron target.

Additional Details:

Documentation:

Implementation Details:

@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves terminal issues related to the terminal electron issues related to the electron target labels Nov 5, 2020
@vince-fugnitto
Copy link
Member Author

I believe @dukengn would like to pick up the issue when he has time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target enhancement issues that are enhancements to current functionality - nice to haves terminal issues related to the terminal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant