custom-editor: changeset unnecessarily pulls '@theia/editor-preview' #9300
Labels
custom-editor
issues related to custom-editor functionality
plug-in system
issues related to the plug-in system
quality
issues related to code and application quality
Bug Description:
The change #8910 adds an unnecessary coupling to
@theia/editor-preview
, and means that downstream applications cannot easily opt-out of using@theia/editor-preview
as part of their application. This is considered a breaking change.I think in this particular instance the coupling can be avoided:
theia/packages/plugin-ext/src/main/browser/custom-editors/custom-editor-opener.tsx
Line 18 in fd91f21
theia/packages/plugin-ext/src/main/browser/custom-editors/custom-editor-opener.tsx
Line 45 in fd91f21
The text was updated successfully, but these errors were encountered: