Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving variables for tasks is not working anymore #9351

Closed
RomanNikitenko opened this issue Apr 14, 2021 · 2 comments
Closed

Resolving variables for tasks is not working anymore #9351

RomanNikitenko opened this issue Apr 14, 2021 · 2 comments
Labels
bug bugs found in the application tasks issues related to the task system

Comments

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Apr 14, 2021

Bug Description:

I detected that resolving variables is not working at least for shell tasks.

Steps to Reproduce:

  1. Add the following task to your tasks.json file
       {
            "type": "shell",
            "label": "TEST RESOLVING TASK",
            "command": "sleep 2 && echo the current file is ${file}"
        }
  1. Open a file.
  2. Run the task
  3. See output for the task

You can try with other variables, like ${workspaceFolder}, for example

The expected behavior: the task's output should contain the path to the open file:

resolving_expected

The actual behavior: there is an empty string instead of the path:

resolving_actual

Additional Information

  • Operating System: Fedora
  • Theia Version: fd91f21

There is an error in the browser console:

error_resolving

@RomanNikitenko RomanNikitenko added bug bugs found in the application tasks issues related to the task system labels Apr 14, 2021
@RomanNikitenko
Copy link
Contributor Author

I tested for theia commit before these changes #9189 and resolving a variable for shell tasks works well for me.
So, it looks like the current issue is a regression after merging #9189.

@RomanNikitenko
Copy link
Contributor Author

The issue was fixed by #9352
thanks @tsmaeder !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application tasks issues related to the task system
Projects
None yet
Development

No branches or pull requests

1 participant