Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TaskResolver should respect VS Code documentation #9411

Open
RomanNikitenko opened this issue Apr 29, 2021 · 1 comment
Open

TaskResolver should respect VS Code documentation #9411

RomanNikitenko opened this issue Apr 29, 2021 · 1 comment
Labels
bug bugs found in the application tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@RomanNikitenko
Copy link
Contributor

Bug Description:

According to the VS Code documentation (please see a description for resolveTask() method):

A valid default implementation for the resolveTask method is to return undefined

At the moment task system does not take into account that resolveTask method can return undefined.
As result the execution of such task fails:

The error is: task ERROR Error resolving task 'test': TypeError: Cannot read property 'group' of undefined

resolving_tasks

Steps to Reproduce:

Please see:

Additional Information
@RomanNikitenko RomanNikitenko added bug bugs found in the application tasks issues related to the task system vscode issues related to VSCode compatibility labels Apr 29, 2021
@RomanNikitenko RomanNikitenko mentioned this issue Apr 29, 2021
Merged
1 task
@RomanNikitenko
Copy link
Contributor Author

RomanNikitenko commented Apr 29, 2021 •
edited
Loading

Possible solution is: #9377 (comment)

The branch for testing: https://github.com/eclipse-theia/theia/compare/fixTaskResolver

It contains:

This was referenced Apr 29, 2021
Closed
Closed
@azatsarynnyy azatsarynnyy mentioned this issue Apr 30, 2021
Closed
11 tasks
@azatsarynnyy azatsarynnyy added che/current-sprint issues taken to the current sprint by Che teams che/next-sprint issues are planned for the next sprint by Che teams Team: Che-Editors issues regarding the che-editors team labels Apr 30, 2021
@azatsarynnyy azatsarynnyy removed the che/next-sprint issues are planned for the next sprint by Che teams label May 18, 2021
@RomanNikitenko RomanNikitenko removed the che/current-sprint issues taken to the current sprint by Che teams label Aug 5, 2021
@RomanNikitenko RomanNikitenko removed their assignment Aug 5, 2021
@RomanNikitenko RomanNikitenko removed the Team: Che-Editors issues regarding the che-editors team label Aug 5, 2021
@vince-fugnitto vince-fugnitto mentioned this issue Aug 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Take into account that TaskResolver can return undefined eclipse-theia/theia
2 participants
@azatsarynnyy @RomanNikitenko