From c772e02ae37262603ecda9814c5d9c2af953ba12 Mon Sep 17 00:00:00 2001 From: Jonas Helming Date: Tue, 12 Sep 2023 21:11:21 +0200 Subject: [PATCH 1/2] Add follow-up section to PR template fixed #12900 Signed-off-by: Jonas Helming --- .github/PULL_REQUEST_TEMPLATE.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 61d10d0b5dfe1..5eb06923af185 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,15 +10,21 @@ vulnerabilities. --> #### What it does + #### How to test + +#### Follow-ups + + + #### Review checklist -- [ ] As an author, I have thoroughly tested my changes and carefully followed [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#requesting-a-review) +- [ ] As an author, I have thoroughly tested my changes and carefully followed [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#requesting-a-review) #### Reminder for reviewers -- As a reviewer, I agree to behave in accordance with [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#reviewing) +- As a reviewer, I agree to behave in accordance with [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#reviewing) From 5911997db6a6ceb88ab9729d75bc50f6494d9afb Mon Sep 17 00:00:00 2001 From: Jonas Helming Date: Thu, 14 Sep 2023 13:13:54 +0200 Subject: [PATCH 2/2] Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Akos Kitta <1405703+kittaakos@users.noreply.github.com> Signed-off-by: Jonas Helming --- .github/PULL_REQUEST_TEMPLATE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5eb06923af185..6f7d691b60110 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -19,12 +19,12 @@ vulnerabilities. #### Follow-ups - + #### Review checklist -- [ ] As an author, I have thoroughly tested my changes and carefully followed [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#requesting-a-review) +- [ ] As an author, I have thoroughly tested my changes and carefully followed [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#requesting-a-review) #### Reminder for reviewers -- As a reviewer, I agree to behave in accordance with [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#reviewing) +- As a reviewer, I agree to behave in accordance with [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#reviewing)