deps: Bump nano to 10.1.3 to avoid axios <1.6.0 #13328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JonasHelming / @tsmaeder: Any update on this PR? |
|
@Torbjorn-Svensson sorry...this one dropped between the cracks. Could you rebase the PR, please? |
axios 1.6.0 fixes CVE-2023-45857 (https://security.snyk.io/vuln/SNYK-JS-AXIOS-6032459). Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
Torbjorn-Svensson
force-pushed
the
pr/bump-to-nano-10.1.3-CVE-2023-45857
branch
from
d6dac1c to
626cd7b
Compare
Rebased on top of 120a822. |
tsmaeder
approved these changes
Feb 21, 2024
This was referenced Feb 29, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axios 1.6.0 fixes CVE-2023-45857
(https://security.snyk.io/vuln/SNYK-JS-AXIOS-6032459).
What it does
Bumps
nanodependency to10.1.3to avoid indirect dependency on vulnerableaxios@<1.6.0.How to test
Not sure how to test.
yarn testfails for me with and without this bump.I have just bumped the dependency and verified that the electron build starts using details described in the quickstart guide
Follow-ups
Review checklist
Reminder for reviewers
Contributed by STMicroelectronics