-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated release publishing #13399
Automated release publishing #13399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks.
I've tried to test yarn publish:latest -- patch
and yarn publish:latest -- minor
with a local verdaccio registry a bit and results looked good.
Just to make sure, @jfaltermeier do you plan to try out the new workflow to publish the new version on Thursday? If that has proven to work, I'll update the documentation to reflect the modified publishing process. |
Yes I plan to try it out. |
@msujew Ok, looks like the publishing failed before all packages have been published (at least I think so): https://github.com/eclipse-theia/theia/actions/runs/8096588531/job/22125663621 I can't see any useful error message unfortunately. I will try to publish the missing pieces |
I think we should at least update the workflow to always create a PR with the changes. |
@jfaltermeier Hm, weird. I would've expected some error message at least. But that's good to know, a publishing process error shouldn't stop the PR from being created. Thanks for the update! |
What it does
Closes #13384
Adds a GitHub action that is triggered on every GitHub release. It automatically publishes the code that is associated with the release. We have a very similar mechanism in Langium. Uses the
NPM_CONFIG_PROVENANCE
env variable to provide provenance. That seems to work with Lerna, see lerna/lerna#3657.How to test
We will see during the next release whether this works as expected. But since the
Publish Next
GitHub Action already works as expected, I don't see too much room for error.Review checklist
Reminder for reviewers