From 26daf22d79027db28cf1343218c81a7ae2ae20b4 Mon Sep 17 00:00:00 2001 From: Vincent Fugnitto Date: Fri, 12 Jul 2019 09:30:26 -0400 Subject: [PATCH] Fix search-in-workspace search result info Fixes #5698 - fixes an issue where the message `No Results Found.` is displayed as a user types and attempts to search. The problem is that the message is displayed before the search actually completes due to a `update()`. Instead, the update to the widget is performed once the `search-in-workspace-tree` completes it's search and fires the event `onDidChange()`. Signed-off-by: Vincent Fugnitto --- .../src/browser/search-in-workspace-widget.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx b/packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx index c6ea741239499..ee274d2e00d05 100644 --- a/packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx +++ b/packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx @@ -355,7 +355,6 @@ export class SearchInWorkspaceWidget extends BaseWidget implements StatefulWidge } else { this.searchTerm = (e.target as HTMLInputElement).value; this.resultTreeWidget.search(this.searchTerm, (this.searchInWorkspaceOptions || {})); - this.update(); } } }