diff --git a/tycho-sbom/src/main/java/org/eclipse/tycho/sbom/TychoProjectDependenciesConverter.java b/tycho-sbom/src/main/java/org/eclipse/tycho/sbom/TychoProjectDependenciesConverter.java index ae852451c9..3bb92d9014 100644 --- a/tycho-sbom/src/main/java/org/eclipse/tycho/sbom/TychoProjectDependenciesConverter.java +++ b/tycho-sbom/src/main/java/org/eclipse/tycho/sbom/TychoProjectDependenciesConverter.java @@ -13,12 +13,14 @@ package org.eclipse.tycho.sbom; import java.util.ArrayList; +import java.util.Collections; import java.util.Comparator; import java.util.HashSet; import java.util.List; import java.util.Map; import java.util.Set; import java.util.TreeSet; +import java.util.concurrent.ConcurrentHashMap; import javax.inject.Inject; @@ -54,6 +56,8 @@ public class TychoProjectDependenciesConverter extends DefaultProjectDependencie @Inject private P2DependencyTreeGenerator dependencyGenerator; + private final Map> bomRepresentations = new ConcurrentHashMap<>(); + @Override public void cleanupBomDependencies(Metadata metadata, Map components, Map dependencies) { @@ -108,38 +112,39 @@ private void convertToDependency(DependencyTreeNode node, Set depend * empty list is returned. * * @param iu The installable unit for which to generate - * @return A {@code mutable} list of all bom representation. matching the given - * IU. + * @return An {@code immutable} list of all bom representations matching the + * given IU. */ private List getBomRepresentation(IInstallableUnit iu) { - final MavenSession mavenSession = legacySupport.getSession(); - final List reactorProjects = mavenSession.getAllProjects(); - // mutable! - List bomRefs = new ArrayList<>(); - // (I) IU describes local reactor project - for (MavenProject project : reactorProjects) { - ReactorProject reactorProject = DefaultReactorProject.adapt(project); - Set initalUnits = reactorProject.getDependencyMetadata(DependencyMetadataType.INITIAL); - Set seedUnits = reactorProject.getDependencyMetadata(DependencyMetadataType.SEED); - if (initalUnits.contains(iu) || seedUnits.contains(iu)) { - String bomRef = modelConverter.generatePackageUrl(project.getArtifact()); + return bomRepresentations.computeIfAbsent(iu, ignore -> { + final MavenSession mavenSession = legacySupport.getSession(); + final List reactorProjects = mavenSession.getAllProjects(); + final List bomRefs = new ArrayList<>(); + // (I) IU describes local reactor project + for (MavenProject project : reactorProjects) { + ReactorProject reactorProject = DefaultReactorProject.adapt(project); + Set initalUnits = reactorProject.getDependencyMetadata(DependencyMetadataType.INITIAL); + Set seedUnits = reactorProject.getDependencyMetadata(DependencyMetadataType.SEED); + if (initalUnits.contains(iu) || seedUnits.contains(iu)) { + String bomRef = modelConverter.generatePackageUrl(project.getArtifact()); + if (bomRef == null) { + LOG.error("Unable to calculate BOM for: " + project); + return Collections.emptyList(); + } + bomRefs.add(bomRef); + return Collections.unmodifiableList(bomRefs); + } + } + // (II) IU describes external artifact + for (IArtifactKey p2artifactKey : iu.getArtifacts()) { + String bomRef = modelConverter.generateP2PackageUrl(p2artifactKey, true, true, false); if (bomRef == null) { - LOG.error("Unable to calculate BOM for: " + project); - return bomRefs; + LOG.error("Unable to calculate BOM for: " + p2artifactKey); + continue; } bomRefs.add(bomRef); - return bomRefs; } - } - // (II) IU describes external artifact - for (IArtifactKey p2artifactKey : iu.getArtifacts()) { - String bomRef = modelConverter.generateP2PackageUrl(p2artifactKey, true, true, false); - if (bomRef == null) { - LOG.error("Unable to calculate BOM for: " + p2artifactKey); - continue; - } - bomRefs.add(bomRef); - } - return bomRefs; // mutable! + return Collections.unmodifiableList(bomRefs); + }); } }