Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

WIP: Providing more optimization for the apache camel springboot example #60

Conversation

ScrewTSW
Copy link
Member

What does this PR do?

This PR adds further optimizations to the previous changes for the apache camel example

What issues does this PR fix or reference?

Follow-up: #46
Issue: https://github.com/redhat-developer/che-functional-tests/issues/556

@ScrewTSW ScrewTSW force-pushed the 556-feature-fix-devfile-quotas-apache-camel branch from cf7a696 to 06aed65 Compare July 25, 2019 14:06
…evfile

Signed-off-by: Tibor Dancs <tdancs@redhat.com>
@ibuziuk
Copy link
Member

ibuziuk commented Jul 25, 2019

@ScrewTSW please explain why those changes will improve the workspace startup / stability in comparrison with the current values ?

@ibuziuk ibuziuk requested a review from apupier July 25, 2019 14:24
@ibuziuk
Copy link
Member

ibuziuk commented Jul 25, 2019

@apupier since you are the primary maintainer of the camel devfile adding you as a reviewer ;-)

@ScrewTSW
Copy link
Member Author

ScrewTSW commented Jul 25, 2019

@ScrewTSW please explain why those changes will improve the workspace startup / stability in comparrison with the current values ?

I've pretty much just reassigned the available resources based on the consumption that I've seen during the testing.

Not saying it's a must, it's just a proposal. The current values work well

@ibuziuk
Copy link
Member

ibuziuk commented Jul 26, 2019

@ScrewTSW could you please provide comparison of RAM consumption for the current version of devfile and the one from PR ? what are the benefits? If, as you said, current values work well why do we need further optimization?

@ScrewTSW ScrewTSW changed the title Providing more optimization for the apache camel springboot example WIP: Providing more optimization for the apache camel springboot example Jul 26, 2019
@ScrewTSW
Copy link
Member Author

Current image memory consumption:

static memory consumptions:

  • JWT Proxy consumes 150MiB
  • Machine exec pod consumes 150MiB
  • Theia consumes 512MB = 488.281MiB

and the plugins defined in the devfile:

  • vscode-xml : 128MiB
  • vscode-apache-camel : 200MiB
  • java lsp : 1400 MiB
  • maven : 512 MiB

That leaves me 43.719MiB to be redistributed.

The memory usage in the LSP peaks at 1250MiB during use and then falls back down as GC takes care of the objects.
Apache camel peaks at 150MiB
Apache XML peaks at 95MiB
and finally Maven with the deployment running and in use peaks around 380 MiB

If you think there's no need to redistribute the extra memory that we have at our disposal, then this PR can be closed.

@ibuziuk
Copy link
Member

ibuziuk commented Jul 26, 2019

@ScrewTSW sorry, but I probably do not understand the math.

That leaves me 43.719MiB to be redistributed.

In the PR you:

  • add 56 MB to vscode-apache-camel
  • removes 120 MB from java plugin
  • removes 28 MB form maven

As I understand your motivation was to redistribute 43.719MiB, but in this PR you literally decrease RAM on 92 MB, and the most worrying thing for me that the RAM for java plugin, which is really memory hungry, is reduced. Am I missing smth ?

@ScrewTSW
Copy link
Member Author

ScrewTSW commented Jul 29, 2019

@ScrewTSW sorry, but I probably do not understand the math.

That leaves me 43.719MiB to be redistributed.

In the PR you:

* add 56 MB to vscode-apache-camel

* removes 120 MB from java plugin

* removes 28 MB form maven

As I understand your motivation was to redistribute 43.719MiB, but in this PR you literally decrease RAM on 92 MB, and the most worrying thing for me that the RAM for java plugin, which is really memory hungry, is reduced. Am I missing smth ?

I have been using those values before I was notified by Angel that he was able to get OOM on the LSP when only using 1Gi of memory.

That's why I've sent my last comment with the analysis and the current status of the image. As I said there, this PR can be closed as irrelevant if you decide that you don't want me to do some magic with the 43Mi we have at our disposal.

I just wanted to bring this image to full 3Gi memory usage (excluding the 3.4....Mi that remains because of the conversion of theia memory consumption from MB to MiB)

@ibuziuk
Copy link
Member

ibuziuk commented Jul 29, 2019

have been using those values before

@ScrewTSW you are using those values now in the current PR :-)
So, if you want some feedback on optimization - bring this image to full 3Gi please update the PR accordingly. If not - just close it

@ScrewTSW
Copy link
Member Author

Closing as irrelevant

@ScrewTSW ScrewTSW closed this Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants