This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Fixed java-web-spring quotas to be able to run on OSIO #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScrewTSW
requested review from
l0rd,
rhopp,
skabashnyuk and
vparfonov
as code owners
ScrewTSW
force-pushed
the
556-feature-fix-devfile-quotas-java-web-spring
branch
from
6b972f4
to
3ff22cb
Compare
5 tasks
amisevsk
reviewed
Jul 25, 2019
ScrewTSW
changed the title
|
so upon investigation there are three constants consuming quota limits:
and the plugins defined in the devfile:
That leaves me 1259.71875MiB to work with. After redistribution this leaves me exactly 3899392 bytes to spare or 3.71875MiB . Java LSP peaked at 1258MiB |
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
ScrewTSW
force-pushed
the
556-feature-fix-devfile-quotas-java-web-spring
branch
from
3ff22cb
to
2eb64a8
Compare
ScrewTSW
changed the title
skabashnyuk
approved these changes
Jul 29, 2019
amisevsk
approved these changes
Jul 29, 2019
| @@ -12,6 +12,7 @@ components: | |||
| - | |||
| type: chePlugin | |||
| id: redhat/java/latest | |||
| memoryLimit: 1512Mi | |||
There was a problem hiding this comment.
This could potentially be dropped, as the default used for redhat/java/latest is 1500Mi. However this would mean any increases to the plugin-registry default would break this devfile again.
l0rd
approved these changes
Jul 29, 2019
ibuziuk
approved these changes
Jul 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the Java Springboot devfile memory quotas in order to be able to run the image on OSIO
What issues does this PR fix or reference?
Issue: https://github.com/redhat-developer/che-functional-tests/issues/556