Configure default cpuLimit and cpuRequest #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vzhukovs
requested review from
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
Was it tested on RHPDS and the dogfooding environment? |
|
@ericwill it was tested on RHPDS, but for RHPDS meta.yaml for the theia-editor needs to be a bit modified. To provide cpuLimit: 1.5 and cpuRequest 0.5. Because there was a fix for 7.23 which provides correct cpu configuration conversion, but che on RHPDS is 7.20.2
As for dogfooding instance. I'm trying to get an access to this host. Will post results of check asap. |
|
Tested on dogfooding instance: |
There was a problem hiding this comment.
I also checked it on our internal dogfooding instance.
LGTM, but up to @ericwill
azatsarynnyy
approved these changes
Jan 20, 2021
16 tasks
ericwill
approved these changes
Jan 20, 2021
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Configure default values for
cpuLimit: 1500mandcpuRequest: 500mfor next tag image.Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#18565
How to test this PR?
Create a workspace from the provided devfile, workspace should be able to start.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.