Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ask user in which container run command if it could be figured out from the workspace panel tree #13764

Closed
mmorhun opened this issue May 16, 2019 · 1 comment
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che

Comments

@mmorhun
Copy link
Contributor

mmorhun commented May 16, 2019

Description

If a command doesn't declare container in which it should be run, we ask user to choose.
In case if user chooser such a command under some specific machine in workspace panel we shouldn't ask, but use the container on which it was invoked.

Reproduction Steps

  1. Create a devfile, define a command, but do not define container for it.
  2. Create a workspace from the devfile and start it.
  3. Open workspace panel, navigate to a container and click on the command.

Expected: the command should be run in the container on which this command was invoked
Actual: user is asked about container in which the command should be run.

@mmorhun mmorhun self-assigned this May 16, 2019
@benoitf benoitf transferred this issue from eclipse-che/che-theia Jul 5, 2019
@benoitf benoitf added the area/editor/theia Issues related to the che-theia IDE of Che label Jul 5, 2019
@mmorhun
Copy link
Contributor Author

mmorhun commented Sep 27, 2019

Done

@mmorhun mmorhun closed this as completed Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che
Projects
None yet
Development

No branches or pull requests

2 participants