Add task plugin #97
Add task plugin #97
Conversation
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
|
|
||
| export const CheWorkspaceClient = Symbol('CheWorkspaceClient'); | ||
|
|
||
| export interface CheWorkspaceClient { |
There was a problem hiding this comment.
Do we really need this interface? Is more than one implementation expected?
There was a problem hiding this comment.
removed, thank you!
|
|
||
| /** | ||
| * Generated using theia-plugin-generator | ||
| */ |
There was a problem hiding this comment.
Is this comment required since the file is generated once and isn't overwritten anymore?
There was a problem hiding this comment.
removed, thank you!
| commands.forEach(command => { | ||
| tasks.push(this.toTask(command)); | ||
| }); | ||
| return tasks; |
There was a problem hiding this comment.
can be simplified to
const commands = await this.cheWorkspaceClient.getCommands();
return commands.map(c => this.toTask(c));
There was a problem hiding this comment.
fixed, thank you!
| const PROJECTS_ROOT_VARIABLE = 'CHE_PROJECTS_ROOT'; | ||
| const ERROR_MESSAGE_TEMPLATE = 'Can not resolve \'current.project.path\' variable.'; | ||
| /** | ||
| * Contributes the path for current project as a relative path to the first directory under the root workspace. |
There was a problem hiding this comment.
Contributes the variable for getting path ... ?
package.json
Outdated
| @@ -3,6 +3,7 @@ | |||
| "private": true, | |||
| "devDependencies": { | |||
| "@types/jest": "24.0.3", | |||
| "@types/jest-diff": "^20.0.1", | |||
There was a problem hiding this comment.
do we have a build and test dependency CQ ?
There was a problem hiding this comment.
removed, thank you!
| @@ -0,0 +1,62 @@ | |||
| { | |||
There was a problem hiding this comment.
package-lock.json file should be removed (we're using yarn workspaces)
There was a problem hiding this comment.
removed, thank you!
plugins/task-plugin/package.json
Outdated
| "theiaPlugin": { | ||
| "backend": "lib/task-plugin-backend.js" | ||
| } | ||
| } |
| import { injectable, inject } from 'inversify'; | ||
| import { CheWorkspaceClient } from '../che-workspace/che-workspace-client'; | ||
|
|
||
| const ReconnectingWebSocket = require('reconnecting-websocket'); |
There was a problem hiding this comment.
from where this dependency is coming from ? (I don't see it in package.json) and there is no CQ
|
|
||
| import * as theia from '@theia/plugin'; | ||
| import * as che from '@eclipse-che/plugin'; | ||
| import 'reflect-metadata'; |
There was a problem hiding this comment.
I see that reflect-metadata is imported more than once in the plug-in while it shouldn't
There was a problem hiding this comment.
fixed, thank you!
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
|
@benoitf I updated the PR, please review. |
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Move task extension functionality to plugin
Related issue: eclipse-che/che#11458
Signed-off-by: Roman Nikitenko rnikiten@redhat.com