Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of 'machine' related terms #14081

Closed
RomanNikitenko opened this issue Jul 31, 2019 · 4 comments
Closed

Get rid of 'machine' related terms #14081

RomanNikitenko opened this issue Jul 31, 2019 · 4 comments
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone
Backlog - Epics

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Jul 31, 2019 •
edited
Loading

Is your enhancement related to a problem? Please describe.

"Machine" has been deprecated and should not be used anywhere in Che anymore.
So we should review our code and use another terms for that.

For example, at the moment task plugin gets info about target container by API as attribute of command machineName and provides this one for machine exec. So at least for task-plugin, machine exec and for che objects changes are required.

Although we display that field as containerName for user, we still use terms machineName and machine in our code. Would be nice to replace these ones with more appropriate terms.

We decided not to do such refactoring before GA, but we should consider to do it after.
@RomanNikitenko RomanNikitenko added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 31, 2019
@RomanNikitenko RomanNikitenko mentioned this issue Jul 31, 2019
Closed
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 31, 2019
@slemeur slemeur added team/ide kind/bug Outline of a bug - must adhere to the bug report template. and removed kind/enhancement A feature request - must adhere to the feature request template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 31, 2019
@slemeur
Copy link
Contributor

slemeur commented Jul 31, 2019

Compatibility will need to be handled.

@slemeur slemeur modified the milestones: 7.x, 7.3.0, 7.1.0 Jul 31, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@benoitf benoitf removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@vparfonov vparfonov mentioned this issue Aug 7, 2019
Closed
11 tasks
@vparfonov vparfonov removed this from the 7.1.0 milestone Oct 2, 2019
@vparfonov vparfonov added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. and removed team/ide kind/bug Outline of a bug - must adhere to the bug report template. labels Oct 30, 2019
@vparfonov vparfonov added this to the Backlog - Epics milestone Oct 30, 2019
@che-bot
Copy link
Contributor

che-bot commented May 12, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2020
@RomanNikitenko RomanNikitenko removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2020
@che-bot
Copy link
Contributor

che-bot commented Jan 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2021
@RomanNikitenko RomanNikitenko removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 11, 2021
@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2021
@che-bot
Copy link
Contributor

che-bot commented Jul 19, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
Backlog - Epics
Development

No branches or pull requests
5 participants
@benoitf @vparfonov @slemeur @RomanNikitenko @che-bot