Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[devworkspace-controller] Propagate errors from provisioning components and/or workspaceRoutings to condition #17455

Closed
Tracked by #19538
amisevsk opened this issue Jul 21, 2020 · 5 comments · Fixed by devfile/devworkspace-operator#385
Closed
Tracked by #19538

[devworkspace-controller] Propagate errors from provisioning components and/or workspaceRoutings to condition #17455

amisevsk opened this issue Jul 21, 2020 · 5 comments · Fixed by devfile/devworkspace-operator#385
Assignees
@amisevsk
Labels
area/devworkspace-operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone
7.30

Comments

@amisevsk
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

With PR devfile/devworkspace-operator#138 some failure reasons are propagated to the user, but the messages for Components and Routing failures are generic and not helpful.

Describe the solution you'd like

We need to propagate the specific reason the controller cannot reconcile Components and WorkspaceRoutings into the condition message.
@amisevsk amisevsk added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Jul 21, 2020
@amisevsk amisevsk mentioned this issue Jul 21, 2020
Merged
@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Jul 25, 2020
@l0rd
Copy link
Contributor

l0rd commented Jul 30, 2020

@amisevsk I am closing this issue because the linked PR is merged. Reopen if the work is not completed yet.

@l0rd l0rd closed this as completed Jul 30, 2020
@sleshchenko
Copy link
Member

The linked PR introduces initial error propagation while this issue is about implementing good failure propagation from multiple components and workspaceRouting.

@sleshchenko sleshchenko reopened this Jul 30, 2020
@che-bot
Copy link
Contributor

che-bot commented Feb 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2021
@che-bot che-bot closed this as completed Feb 24, 2021
@sleshchenko sleshchenko reopened this Feb 25, 2021
@l0rd l0rd added this to the DevWorkspace Integration - STEP2 milestone Mar 5, 2021
@che-bot che-bot closed this as completed Mar 17, 2021
@amisevsk amisevsk reopened this Mar 17, 2021
@amisevsk amisevsk added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 17, 2021
@amisevsk
Copy link
Contributor Author

We should consider migrating this issue to the devworkspace-operator repo.

@sleshchenko sleshchenko mentioned this issue Mar 30, 2021
Merged
@l0rd l0rd removed this from the DevWorkspace Integration - STEP2 milestone Apr 8, 2021
@l0rd l0rd mentioned this issue Apr 8, 2021
Closed
29 tasks
@amisevsk amisevsk self-assigned this Apr 14, 2021
@amisevsk amisevsk mentioned this issue Apr 14, 2021
Merged
@sleshchenko sleshchenko mentioned this issue Apr 15, 2021
Closed
29 tasks
@sleshchenko sleshchenko added this to the 7.30 milestone Apr 15, 2021
@themr0c
Copy link
Contributor

themr0c commented Jun 2, 2021

Release notes: https://issues.redhat.com/browse/CRW-1866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amisevsk amisevsk

Labels
area/devworkspace-operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Milestone
7.30
Development

Successfully merging a pull request may close this issue.

Routing errors propagation amisevsk/devworkspace-operator
5 participants
@themr0c @l0rd @sleshchenko @amisevsk @che-bot