Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current directory when opening a terminal in Che-Code should be the project folder #21133

Closed
azatsarynnyy opened this issue Feb 7, 2022 · 0 comments · Fixed by che-incubator/che-code#51
Closed

Current directory when opening a terminal in Che-Code should be the project folder #21133

azatsarynnyy opened this issue Feb 7, 2022 · 0 comments · Fixed by che-incubator/che-code#51
Assignees
@benoitf
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Milestone
7.49

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Feb 7, 2022 •
edited by l0rd
Loading

Is your enhancement related to a problem? Please describe

When the user opens a terminal, in Che-Code, it uses PROJECTS_ROOT as a current working directory:

image

It's not convenient as each time one needs to go to the actual project sources folder in order to execute a command on the project.

Describe the solution you'd like

Use PROJECT_SOURCE as a current working directory when opening a terminal in a single-folder workspace.

image

Describe alternatives you've considered

When opening a terminal for a multi-folder workspace, PROJECTS_ROOT can be used instead.

Release Notes Text

The current directory when opening a terminal in Che-Code should be the root folder of the workspaces project. The path of that folder is set in the environment variable PROJECT_SOURCE.
@azatsarynnyy azatsarynnyy added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. team/editors area/editor/vscode Issues related to the Code OSS editor of Che labels Feb 7, 2022
@benoitf benoitf self-assigned this May 19, 2022
@benoitf benoitf mentioned this issue May 19, 2022
Merged
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Jun 2, 2022
@l0rd l0rd changed the title Che-Code should open a terminal with the PROJECT_SOURCE as a current working directory Current directory when opening a terminal in Che-Code should be the project folder Jun 2, 2022
@azatsarynnyy azatsarynnyy added this to the 7.49 milestone Jun 3, 2022
@max-cx max-cx removed the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitf benoitf

Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.49
Development

Successfully merging a pull request may close this issue.

feat: filter containers and open terminal in the right folder (project's folder) benoitf/che-code
4 participants
@benoitf @l0rd @azatsarynnyy @max-cx