if with instanceof pattern match and && breaks completion in nested if

[mfussenegger]

Using eclipse.jdt.ls from master (63713d5) and Java 16.0.1 the following code snippet breaks completion in the inner if branch:

public class App {

    static class Symbol {
    }

    static class Ref extends Symbol {


       String name() {
          return "foo";
       }
    }

    static class Literal extends Symbol {
    }

    public void test(Symbol x, Symbol y) {
        if (x instanceof Ref ref && y instanceof Literal lit) {
          // ref.| completion works here, showing expected options
          if (ref.name() == "foo") {
            // ref.| completion doesn't work here - only shows `class` as an option
          }
        }
    }
}

As soon as the && y instanceof .. part is removed the completion starts to work

I suspect this is an upstream jdt bug

[fbricon]

Yup, same issue in Eclipse IDE. Can you open a ticket in https://bugs.eclipse.org/bugs/enter_bug.cgi?product=JDT?

[mfussenegger]

Done: https://bugs.eclipse.org/bugs/show_bug.cgi?id=575599

[fbricon]

thanks

[rgrunber]

Thanks for filing upstream. Should be fixed in the next release.