Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] "Add parentheses around cast" doesn't work as expected #907

Closed
fbricon opened this issue Dec 17, 2018 · 1 comment
Closed

Comments

@fbricon
Copy link
Contributor

fbricon commented Dec 17, 2018

There are 3 unit tests that pass (when they shouldn't, but that's another story), where "Add parentheses around cast" should actually add parentheses, but instead remove the cast in:

    public void foo(Object o) {
        String x= (String) o.substring(1);
    }

remove-parens

The tests are being rewritten and will be ignored for now, but I'm not sure what the actual issue is. The title is correct, the textedit is not. Stock Eclipse behaves properly, so it could be something we do in jdt.ls specifically.

@fbricon
Copy link
Contributor Author

fbricon commented Dec 20, 2018

Tests to re-enable: ac29343#diff-525ef54ce68546beb0b4262b89013756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants