Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Remark 1.0.0 -> 1.2.0 for Markdown Tables #1167

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Updated Remark 1.0.0 -> 1.2.0 for Markdown Tables #1167

merged 1 commit into from
Sep 9, 2019

Conversation

NikolasKomonen
Copy link
Contributor

This PR uses the next version of Remark which fixes issues with tables converted to markdown.
Some issues this fixes are:

  1. Tables without a header
  2. Tables with an improperly defined header (no THEAD tag)
  3. Some table indentation issues (fixed in JDT.ls)

@NikolasKomonen
Updated to remark 1.2.0
dc41cd1 
Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
@fbricon
Copy link
Contributor

fbricon commented Sep 9, 2019

Awesome! Thanks @NikolasKomonen !

@fbricon fbricon merged commit a82005c into eclipse-jdtls:master Sep 9, 2019
@fbricon fbricon added this to the Mid September 2019 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Mid September 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@NikolasKomonen @fbricon