Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build workspace action can report progress to client #1368

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Feb 27, 2020

Change computeAsync to computeAsyncWithClientProgress when executing build workspace.

Given the building task may take some time to execute, this could make the client print the trace if the server trace is turned on.

Also fix a type reference in JavaDoc

Signed-off-by: Sheng Chen <sheche@microsoft.com>
@fbricon
Copy link
Contributor

fbricon commented Feb 28, 2020

I'm not seeing any more progress report with this change

@jdneo
Copy link
Contributor Author

jdneo commented Mar 2, 2020

If config the setting java.trace.server to verbose, more progress can be seen in the output channel, for example:

[Trace - 10:15:08 AM] Received notification 'language/progressReport'.
Params: {
    "task": "Background task",
    "subTask": "(Found 11 warnings) Compiling spring-petclinic/src/test/java/org/springframework/samples/petclinic/model",
    "status": "87% (Found 11 warnings) Compiling spring-petclinic/src/test/java/org/springframework/samples/petclinic/model",
    "totalWork": 1000,
    "workDone": 868,
    "complete": false
}

@fbricon
Copy link
Contributor

fbricon commented Mar 2, 2020

test this please

@fbricon
Copy link
Contributor

fbricon commented Mar 2, 2020

I see. I was expecting to see new progress reports in the Java Build Status view in VS Code. Maybe something to improve then

@fbricon fbricon merged commit b881de5 into eclipse-jdtls:master Mar 2, 2020
@fbricon fbricon added this to the Early March 2020 milestone Mar 2, 2020
@jdneo jdneo deleted the cs/progress branch March 3, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants