Support semantic tokens #1408
Merged
Support semantic tokens #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan Zhang <yanzh@microsoft.com> remove unused file Signed-off-by: Yan Zhang <yanzh@microsoft.com>
fbricon
requested changes
Apr 15, 2020
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/semantictokens/ITokenModifier.java
Show resolved
Hide resolved
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/commands/SemanticTokensCommand.java
Show resolved
Hide resolved
...e.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/semantictokens/SemanticTokensVisitor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
|
Thanks @Eskibear! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about Semantic Highlighting. VS Code has already support to register providers via its APIs, LSP proposal is in progress, but it's not yet part of LSP for the moment.
In this PR, a delegate command to respond to the semantic token request, before it's merged into LSP in the coming version.
Basically the LS tells clients a list of encoded tokens and the legend, and then client is reponsible for applying the tokens with proper textmate scopes and related styles.
Two token types
variableandmethodare supported.Token modifiers include
public,private,protected,abstract,final,static,deprecatedBelow is how it looks in vscode after applying styles for some modifiers: