Enhance MavenProjectImporter to stop scanning the specified exclusion list #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
I'll have a look at this soon. |
rgrunber
reviewed
Jan 7, 2021
There was a problem hiding this comment.
Change seems to work. BasicFileDetector is doing the work the previous code was.
At first I wasn't sure how changes in applies(..) would affect anything but it's as you said. LocalProjectScanner is being passed an incorrect folder rather than the directories that have been verified. I think this can be merged.
testforstephen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#1698
The issue happens because the LocalProjectScanner class ignores the java.import.exclusions property and always scans the whole directory.
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com