Correct minor typo in exception message #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
b0ssi
force-pushed
the
issue-1833-fix-typo
branch
from
56aff58
to
1b5295f
Compare
rgrunber
requested changes
Mar 12, 2021
There was a problem hiding this comment.
👍 Nice catch on the possessive form.
The Eclipse Contributor Agreement needs to be signed. It's not too huge a pain but they are looking to streamline the process. https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#Eclipse_Contributor_Agreement
You just need to create an account and sign the ECA. If you have any troubles setting things up, let me know.
b0ssi
force-pushed
the
issue-1833-fix-typo
branch
from
1b5295f
to
82fe136
Compare
* Correct a minor typo in the exception message that responds to a failed attempt to add a folder to the Java source path which is already implicitly included by one of its parents Signed-off-by: bossi <bossi@isotoxin.de>
b0ssi
force-pushed
the
issue-1833-fix-typo
branch
from
82fe136
to
30b0e55
Compare
|
Thanks @rgrunber, I was suspecting even the local grammar police needs to sign :p - should be all good to go now. Thanks for pointing into the right direction! 🚀 |
testforstephen
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct a minor typo in the exception message that responds to a failed attempt to add a folder to the Java source path which is already implicitly included by one of its parents.
Fixes redhat-developer/vscode-java#1833