Set o.e.j.c.formatter.indent_switchstatements_compare_to_switch=true by default #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
requested changes
Oct 28, 2021
There was a problem hiding this comment.
Would it be possible to rename getJavaLSDefaultFormatterSettings to getCombinedDefaultFormatterSettings and create a method getJavaLSDefaultFormatterSettings that just returns a map of the (4) formatter settings we intend to override.
This way the code in PreferenceManager.initializeJavaCoreOptions(..) can just call it instead of having to copy values in 2 separate locations.
...eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/FormatterHandlerTest.java
Outdated
Show resolved
Hide resolved
|
@rgrunber I have updated the PR. |
rgrunber
reviewed
Oct 28, 2021
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/PreferenceManager.java
Outdated
Show resolved
Hide resolved
…by default Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#2185
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com