Show "Add javadoc for" in quick assists

[CsCherrYY]

Signed-off-by: Shi Chen chenshi@microsoft.com

javadoc.mp4

[rgrunber]

Change seems to be working well for me. Just some questions about placement of the new functionality.

[rgrunber]

Overall, the change works well. Just one thing I noticed. Not sure if it has any implications :

In this example, I set the property org.eclipse.jdt.core.compiler.problem.missingJavadocComments=warning

No quick fixes available. Of course if we trigger code action, we'll be able to fix it, but that display can be a bit confusing. I don't think many users choose to activate quick-fixes that way, but I wonder if this might affect other clients negatively.

Is there any way to preserve the quick-fix for the diagnostic while not duplicating it when triggered as a code action ?

[CsCherrYY]

@rgrunber A solution is that we can separate these two kinds: if there is a problem about Missing javadoc comment (Although it's
not a default value, user can define it via .settings), we provide a QuickFix, otherwise a QuickAssist.

And we can also keep a better order under this situation: A QuickFix should have a higher priority on the client side since it will have a related diagnostic, while a QuickAssist does not. In this way, we can have a way to put a QuickAssist, which will add javadoc under other quick assists, e.g., generating accessors, the related work will be available in #2109.

quickfixandassist.mp4

[rgrunber]

LGTM. Feel free to squash + rebase merge so we can include in the release.