Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order for configuration updating options #2135

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Jun 20, 2022

part of redhat-developer/vscode-java#2473

Before, the highlighted option is Never. This PR changes the order of the options so that Yes will be highlighted.

Before

WeChat Screenshot_20220616085436

Now

WeChat Screenshot_20220620145342

Note: I changed the word Now to Yes to make it sounds more straight-forward. @rgrunber Is this word change makes sense to you? (Since you are native speaker 😄 )

Signed-off-by: Sheng Chen sheche@microsoft.com

Signed-off-by: Sheng Chen <sheche@microsoft.com>
@jdneo
Copy link
Contributor Author

jdneo commented Jun 20, 2022

test this please

@rgrunber
Copy link
Contributor

Yes, this makes a lot more sense. :)

@rgrunber rgrunber changed the title Change the order for configuartion updating options Change the order for configuration updating options Jun 20, 2022
@rgrunber rgrunber merged commit a9b3880 into master Jun 20, 2022
@rgrunber rgrunber deleted the cs/issue-2473-2 branch June 20, 2022 14:06
@rgrunber rgrunber added this to the End June 2022 milestone Jun 20, 2022
@rgrunber rgrunber added the bug label Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants