Show toString()/hashCode() and equals() fields in definition order #2212
Conversation
Signed-off-by: Shi Chen <chenshi@microsoft.com>
|
test this please |
CsCherrYY
changed the title
There was a problem hiding this comment.
Change looks fine to me, so feel free to merge after renaming the comparator.
This also fixes the hashCode/equals quick-assist since they call the same method :)
Would have been great to use IType.getFields() directly but I guess everything is based on the ITypeBinding -> IVariableBinding [] and mapping between an IField and an IVariableBinding could be just as hacky.
| return Arrays.stream(typeBinding.getDeclaredFields()).sorted(new IVariableBindingComparator()).filter(f -> includeStatic || !Modifier.isStatic(f.getModifiers())).map(f -> new LspVariableBinding(f)).toArray(LspVariableBinding[]::new); | ||
| } | ||
|
|
||
| public static class IVariableBindingComparator implements Comparator<IVariableBinding> { |
There was a problem hiding this comment.
Make it VariableBindingComparator. Otherwise it'll be confused for an interface based on Java naming convention.
You're right. I just tried this before and find it's tricky to mapping the fields between an |
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Signed-off-by: Shi Chen chenshi@microsoft.com
fix redhat-developer/vscode-java#2502
Sort IVariableBindings before return to the client/after receiving pick results from the client.