Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a reasonable guess for the name of the extracted method #2670

Merged

Conversation

JessicaJHee
Copy link
Contributor

@JessicaJHee JessicaJHee commented May 26, 2023

Fixes #2011

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Co-authored-by: Jessica He <jhe@redhat.com>
@rgrunber rgrunber self-requested a review June 2, 2023 02:41
@rgrunber
Copy link
Contributor

rgrunber commented Jun 2, 2023

I think in the future we'll need to also handle cases like inferring names from just the other method invocation as well. For now this looks like a good first step.

@rgrunber rgrunber merged commit 0e04fdd into eclipse-jdtls:master Jun 2, 2023
@rgrunber rgrunber added this to the End June 2023 milestone Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better infer extracted method name based on context
2 participants