Make the checksum download task work in parallel #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Very nice. About a 30% improvement here. Contents of the json files are identical before/after. It's basically as fast as completely skipping the checksum generation!
It removes the println, but with an operation that's so fast, there's less of a need to print status.
Update: Just a minor nitpick on the title.
snjeza
approved these changes
Jul 14, 2023
Signed-off-by: Sheng Chen <sheche@microsoft.com>
rgrunber
force-pushed
the
cs/parallel-checksum-download
branch
from
1230194
to
f449afe
Compare
rgrunber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the gradle wrapper checksum download task to be parallelly. This will extremely boost the speed of the build.