New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the mechanism to resolve the package name for empty java file #950

Merged

fbricon merged 1 commit into eclipse-jdtls:master from testforstephen:jinbo_fixpackageName

Mar 14, 2019

Contributor

testforstephen commented Mar 5, 2019 •

edited

Loading

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

Fixes redhat-developer/vscode-java#750

Follow the priority below to infer the package name for an empty java file.

Try to search whether a nearby non-empty java file exists in the same directory. If so, use the nearby non-empty file to compute the package name.
Try to find whether the java file is under src folder. If so, compute the package name beginning from the src path.
Compute the relative path with the workspaceRoot and use that as the package name.


          Improve the mechanism to resolve the package name for empty java file

ffe77b1

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

testforstephen force-pushed the jinbo_fixpackageName branch from 329813e to ffe77b1 Compare

March 5, 2019 06:37

fbricon merged commit b39107e into eclipse-jdtls:master

Contributor

fbricon commented Mar 14, 2019

Thanks @testforstephen

fbricon added enhancement standalone-files labels

fbricon added this to the Mid March 2019 milestone

testforstephen deleted the jinbo_fixpackageName branch

March 15, 2019 01:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement standalone-files