Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad element formatting is replaced with <null> #1034

Closed
rgrunber opened this issue May 17, 2021 · 1 comment
Closed

Bad element formatting is replaced with <null> #1034

rgrunber opened this issue May 17, 2021 · 1 comment
Labels
bug Something isn't working formatting This issue or enhancement is related to formatting support
Milestone
0.21.0

Comments

@rgrunber
Copy link
Contributor

rgrunber commented May 17, 2021 •
edited by angelozerr
Loading

Takes a sampel with https://ejs.co/ syntax.

<foo>
  <url><%= url %></url>
</foo>

After formatting, we have:

<foo>
	<url>
		<null>
	</url>
</foo>

Currently the <% tags get replaced with <null>
@angelozerr angelozerr changed the title Support for embedded javascript (EJS) Bad element formatting is replaced with <null> May 18, 2021
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 18, 2021
@angelozerr
Bad element formatting is replaced with <null>
7d4e456 
Fixes eclipse-lemminx#1034

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue May 18, 2021
Closed
@angelozerr angelozerr added bug Something isn't working formatting This issue or enhancement is related to formatting support labels May 19, 2021
@angelozerr angelozerr mentioned this issue May 19, 2021
Closed
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 20, 2021
@angelozerr
Bad element formatting is replaced with <null>
9d4b5cd 
Fixes eclipse-lemminx#1034

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Jan 4, 2022
@angelozerr
Bad element formatting is replaced with <null>
d8468b7 
Fixes eclipse-lemminx#1034

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Jan 4, 2022
@angelozerr
Bad element formatting is replaced with <null>
216920f 
Fixes eclipse-lemminx#1034

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor

This issue should be fixed by the experimental formatter https://github.com/redhat-developer/vscode-xml/blob/master/docs/Formatting.md#xmlformatexperimental

@angelozerr angelozerr added this to the 0.21.0 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working formatting This issue or enhancement is related to formatting support
Projects
None yet
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

Bad element formatting is replaced with <null> angelozerr/lemminx
2 participants
@rgrunber @angelozerr