Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report schema identifier of XML document through telemetry event #1105

Closed
rgrunber opened this issue Aug 23, 2021 · 0 comments · Fixed by #1106
Closed

Report schema identifier of XML document through telemetry event #1105

rgrunber opened this issue Aug 23, 2021 · 0 comments · Fixed by #1106
Milestone
0.18.1

Comments

@rgrunber
Copy link
Contributor

As discussed in #1066 , one of the things that language clients might care to know, is what XML schemas are most popular. This might help focus efforts towards relevant support. For example, if a lot of people are using http://maven.apache.org/xsd/maven-4.0.0.xsd, then maybe more focus on lemminx-maven should be given.

As with the previous issue, this can be done through https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/extensions/contentmodel/model/ReferencedGrammarInfo.java
rgrunber added a commit to rgrunber/lemminx that referenced this issue Aug 23, 2021
@rgrunber
Report grammar identifier to didOpen telemetry events.
503a4ea 
- Fixes eclipse-lemminx#1105
- When exactly 1 grammar reference exists per file, simply send the
  relevant values (not a list of size 1). Otherwise, send the values as
  a list

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber mentioned this issue Aug 23, 2021
Merged
rgrunber added a commit to rgrunber/lemminx that referenced this issue Aug 24, 2021
@rgrunber
Report grammar identifier to didOpen telemetry events.
4061c08 
- Fixes eclipse-lemminx#1105
- Do not report local grammars
- When exactly 1 grammar reference exists per file, simply send the
  relevant values (not a list of size 1). Otherwise, send the values as
  a list

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/lemminx that referenced this issue Aug 27, 2021
@rgrunber
Report grammar identifier to didOpen telemetry events.
f4a2daf 
- Fixes eclipse-lemminx#1105
- Do not report local grammars
- When exactly 1 grammar reference exists per file, simply send the
  relevant values (not a list of size 1). Otherwise, send the values as
  a list

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@angelozerr angelozerr added this to the 0.18.1 milestone Aug 27, 2021
angelozerr pushed a commit that referenced this issue Aug 27, 2021
@rgrunber @angelozerr
Report grammar identifier to didOpen telemetry events.
a3058b7 
- Fixes #1105
- Do not report local grammars
- When exactly 1 grammar reference exists per file, simply send the
  relevant values (not a list of size 1). Otherwise, send the values as
  a list

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.18.1
Development

Successfully merging a pull request may close this issue.

Report grammar identifier to didOpen telemetry events. rgrunber/lemminx
2 participants
@rgrunber @angelozerr