Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Insert element" CodeActions don't add close tags when auto close tag is disabled #1458

Closed
datho7561 opened this issue Jan 24, 2023 · 0 comments · Fixed by #1462
Closed

"Insert element" CodeActions don't add close tags when auto close tag is disabled #1458

datho7561 opened this issue Jan 24, 2023 · 0 comments · Fixed by #1462
Labels
bug Something isn't working code action
Milestone
0.24.0

Comments

@datho7561
Copy link
Contributor

If you set "xml.completion.autoCloseTags": false, then any code action that generates missing elements doesn't generate the end tag.

This happens for XML files linked to XSD and RNG. (files linked to DTD don't have this type of code action as of the time of writing).
@datho7561 datho7561 added bug Something isn't working code action labels Jan 24, 2023
@JessicaJHee JessicaJHee mentioned this issue Jan 24, 2023
Merged
@datho7561 datho7561 added this to the 0.24.0 milestone Jan 25, 2023
@datho7561 datho7561 moved this to 👀 In review in IDE Cloudaptors Jan 25, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working code action
Projects
None yet
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

Generate end tag with xml.completion.autoCloseTags set to false JessicaJHee/lemminx
1 participant
@datho7561