Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump LSP4J version 0.14.0 to 0.20.1 #1497

Closed
w6et opened this issue Mar 2, 2023 · 3 comments
Closed

bump LSP4J version 0.14.0 to 0.20.1 #1497

w6et opened this issue Mar 2, 2023 · 3 comments
Assignees
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@w6et
Copy link
Contributor

w6et commented Mar 2, 2023

LSP4J 0.20.1 has now been released
lemminx now just use 0.14.0,i suggest bump the version 0.14.0 to 0.20.1
benefit:

  • some bugfix from 0.14.0 to 0.20.1
  • lsp4j runtime base on java8(compatible)

code change:
org.eclipse.lemminx.XMLTextDocumentService#prepareRename

Either<Range, PrepareRenameResult> either = getXMLLanguageService().prepareRename(xmlDocument, params.getPosition(), cancelChecker);
if (either != null) {
	if(either.isLeft()) {
		return Either3.forFirst((Range)either.get());
	}else {
		return Either3.forSecond((PrepareRenameResult)either.get());
	}
}else {
	return null;
}
//return getXMLLanguageService().prepareRename3(xmlDocument, params.getPosition(), cancelChecker);

#在 LSP4J 0.15.0
Return type of textDocument/prepareRename changed from Either<Range, PrepareRenameResult>
to Either3<Range, PrepareRenameResult, PrepareRenameDefaultBehavior>

@angelozerr
Copy link
Contributor

@w6et is there any chance that you create a PR?

@w6et
Copy link
Contributor Author

w6et commented Mar 2, 2023

@w6et is there any chance that you create a PR?

/eclipse/lemminx/pull/1498

@datho7561 datho7561 added the dependencies Pull requests that update a dependency file label Mar 7, 2023
@datho7561 datho7561 added this to the 0.25.0 milestone Mar 7, 2023
@datho7561
Copy link
Contributor

Closed in #1498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants