Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No completion nor validation when editing an xsd schema #178

Closed
fbricon opened this issue Oct 29, 2018 · 11 comments
Closed

No completion nor validation when editing an xsd schema #178

fbricon opened this issue Oct 29, 2018 · 11 comments
Assignees
Labels
completion This issue or enhancement is related to completion support enhancement New feature or request validation XSD
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented Oct 29, 2018

<?xml version="1.1"?>
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified" attributeFormDefault="unqualified">
   <xs:  <!-- no completion here -->
   <foo>bar</foo> <!-- no error here -->
</xs:schema>
@fbricon fbricon added bug Something isn't working completion This issue or enhancement is related to completion support validation labels Oct 29, 2018
@tenluap
Copy link

tenluap commented Oct 29, 2018

same here too.

@angelozerr
Copy link
Contributor

@fbricon I think we should not mark this issue as bug, because it's a new feature. Indeed we need to implement a custom validation to validate XML Schema like WTP does https://github.com/eclipse/webtools.sourceediting/blob/master/xml/bundles/org.eclipse.wst.xsd.core/src-validation/org/eclipse/wst/xsd/core/internal/validation/XSDValidator.java

For completion, I don't know how to implement that (it works with WTP but I don't find where it is implemented).

@angelozerr angelozerr added enhancement New feature or request XSD and removed bug Something isn't working labels Oct 31, 2018
@angelozerr angelozerr self-assigned this Oct 31, 2018
@angelozerr angelozerr added this to the v0.0.2 milestone Oct 31, 2018
@angelozerr
Copy link
Contributor

I'm working on this issue.

@fbricon
Copy link
Contributor Author

fbricon commented Nov 2, 2018

8967764 doesn't fix this issue for the moment

@angelozerr
Copy link
Contributor

@fbricon you must wait for around 1 minutes before having validation and completion (it's not usable)

@fbricon
Copy link
Contributor Author

fbricon commented Nov 2, 2018

@angelozerr No, not for that specific use case, where no xsd url is defined, just the systemId. I got nothing after several minutes.

@angelozerr
Copy link
Contributor

angelozerr commented Nov 2, 2018

Sorry @fbricon, I have not seen that you have not specify some namespace. I'm supporting this feature, a commit will come soon.

angelozerr added a commit that referenced this issue Nov 2, 2018
@angelozerr
Copy link
Contributor

@fbricon please retry, it should work and if you disable cache, it should be fast too since XML Schema is deployed from classpath.

@fbricon
Copy link
Contributor Author

fbricon commented Nov 2, 2018

Works nicely now, thanks!

@fbricon
Copy link
Contributor Author

fbricon commented Nov 2, 2018

even when working offline without any cache. Closing.

@fbricon fbricon closed this as completed Nov 2, 2018
@angelozerr
Copy link
Contributor

Thanks @fbricon for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completion This issue or enhancement is related to completion support enhancement New feature or request validation XSD
Projects
None yet
Development

No branches or pull requests

3 participants