-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate XML Schema #190
Comments
@fbricon this issue starts working: I'm writing tests and after I will able to commit my work, can I do that or you prefer creating release before? |
Open a PR, that way we can test it and if safe to merge before the release, then we'll do that |
When you think you could do the release? |
Depends on @NikolasKomonen. Hopefully later today or tomorrow, once everything is done. See https://waffle.io/redhat-developer/vscode-xml?milestone=v0.0.2,0.2.0 |
@fbricon I have commited my work but XSD validator is not enable . If you want to play with it, you must just uncomment https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/xsd/participants/diagnostics/XSDDiagnosticsParticipant.java#L38 |
I'd have preferred you opened a PR. That commit contains significant changes, even if it's not enabled by default |
DO you want I revert my work? |
Sorry @fbricon I will do it next time -( |
@fbricon I'm writting test for this feature. Do you think I can enable it once test will be finished or you prefer waiting for creating release 0.2 before I activate it. |
go ahead. If it breaks something, we'll revert before releasing |
After writing tests, I have seen that there is some trouble, so I prefer not enabling the XSD validation. I must study more Xerces source code to understand the problem. In other words you can create release now if you wish. |
Signed-off-by: azerr <azerr@redhat.com>
Signed-off-by: azerr <azerr@redhat.com>
Signed-off-by: azerr <azerr@redhat.com>
Signed-off-by: azerr <azerr@redhat.com>
It should be cool to validate XML Schema types. takes a sample like this:
Eclipse WTP XML Editor display those following errors:
The text was updated successfully, but these errors were encountered: