Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-closing tag doesn't remove end tag if tag name contains uppercase chars #354

Closed
fbricon opened this issue Apr 16, 2019 · 0 comments
Closed
Labels
bug Something isn't working completion This issue or enhancement is related to completion support
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented Apr 16, 2019

Given

<root>
	<foo></foo>
	<bAr></bAr>
</root>

self-closing foo correctly removes the closing tag, but it doesn't work for bAr, as it contains an upper case character.
Apr-16-2019 19-02-32

@fbricon fbricon added bug Something isn't working completion This issue or enhancement is related to completion support labels Apr 16, 2019
@fbricon fbricon changed the title Self-closing tag doesn't compress end tag if tag name contains uppercase chars Self-closing tag doesn't remove end tag if tag name contains uppercase chars Apr 16, 2019
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 18, 2019
…ith capitals in their name

didn't autoclose

Fixes redhat-developer/vscode-xml#126 , eclipse-lemminx#354

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 23, 2019
…ith capitals in their name

didn't autoclose

Fixes redhat-developer/vscode-xml#126 , eclipse-lemminx#354

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
fbricon pushed a commit that referenced this issue Apr 24, 2019
... and autoclosing elements with capitals in their name

Fixes redhat-developer/vscode-xml#126 , #354

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
@fbricon fbricon added this to the v0.6.0 milestone Apr 24, 2019
@fbricon fbricon closed this as completed Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completion This issue or enhancement is related to completion support
Projects
None yet
Development

No branches or pull requests

1 participant