Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to rename a namespace. #366

Closed
NikolasKomonen opened this issue May 2, 2019 · 1 comment · Fixed by #403
Closed

Ability to rename a namespace. #366

NikolasKomonen opened this issue May 2, 2019 · 1 comment · Fixed by #403
Assignees
@NikolasKomonen
Labels
good first issue Good for newcomers
Milestone
v0.7.0

Comments

@NikolasKomonen
Copy link
Contributor

NikolasKomonen commented May 2, 2019 •
edited
Loading

If the main namespace name is highlighted, and rename is called on it, replace all instances of it in the element names.

eg:

<root xmlns:xs="...">
<xs:element />
<xs:complexType />
<root xmlns:xs="...">  <!-- highlight 'xs' and renamed to 'xsd' -->
<xs:element />
<xs:complexType />
<root xmlns:xsd="...">
<xsd:element />
<xsd:complexType />
@NikolasKomonen NikolasKomonen added the good first issue Good for newcomers label May 2, 2019
@angelozerr
Copy link
Contributor

+1 !

@NikolasKomonen NikolasKomonen added this to the v0.7.0 milestone May 21, 2019
@NikolasKomonen NikolasKomonen mentioned this issue May 29, 2019
Merged
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue May 29, 2019
@angelozerr @NikolasKomonen
Improved namespace renaming for XML/XSD documents
25d9b55 
Fixes eclipse-lemminx#366

Can rename namespace declaration and all will change, renaming element with namespace does not wipe
namespace, attribute values referencing a namespace will update if necessary

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue May 29, 2019
@angelozerr @NikolasKomonen
Improved namespace renaming for XML/XSD documents
094e9a2 
Fixes eclipse-lemminx#366

Can rename namespace declaration and all will change, renaming element with namespace does not wipe
namespace, attribute values referencing a namespace will update if necessary

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue May 29, 2019
@angelozerr @NikolasKomonen
Improved namespace renaming for XML/XSD documents
f0d9a81 
Fixes eclipse-lemminx#366

Can rename namespace declaration and all will change, renaming element with namespace does not wipe
namespace, attribute values referencing a namespace will update if necessary

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue May 29, 2019
@angelozerr @NikolasKomonen
Improved namespace renaming for XML/XSD documents
bc45fa5 
Fixes eclipse-lemminx#366

Can rename namespace declaration and all will change, renaming element with namespace does not wipe
namespace, attribute values referencing a namespace will update if necessary

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue May 29, 2019
@angelozerr @NikolasKomonen
Improved namespace renaming for XML/XSD documents
8fc1179 
Fixes eclipse-lemminx#366

Can rename namespace declaration and all will change, renaming element with namespace does not wipe
namespace, attribute values referencing a namespace will update if necessary

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue May 30, 2019
@angelozerr @NikolasKomonen
Improved namespace renaming for XML/XSD documents
c4459ba 
Fixes eclipse-lemminx#366

Can rename namespace declaration and all will change, renaming element with namespace does not wipe
namespace, attribute values referencing a namespace will update if necessary

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
angelozerr added a commit that referenced this issue May 31, 2019
@angelozerr
Improved namespace renaming for XML/XSD documents
d4cf351 
Fixes #366

Can rename namespace declaration and all will change, renaming element with namespace does not wipe
namespace, attribute values referencing a namespace will update if necessary

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolasKomonen NikolasKomonen

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Improved namespace renaming for XML/XSD NikolasKomonen/lsp4xml
2 participants
@angelozerr @NikolasKomonen