-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documents with an Internal Subset DOCTYPE had stopped trying to bind #379
Comments
@zwaldowski could you please share a little vscode project with cases that you are describing please and give us trouble that you have (completion that you are waiting). Thanks! |
See here. See the screenshots in the gist's comments. I was having trouble getting the |
Thank's @zwaldowski for your feedback. I tested with your article.xml and I have the same issue but WTP XML Editor from Eclipse display the same errors. I'm not sure that we can mix internal DTD and XML Schema like this? |
I'm not familiar with WTP XML Editor. When we use Jing to render these documents, we bind a RelaxNG schema to it and it handles the entities fine. We've done this for ~15 years. Can you help me understand why this shouldn't work another way, perhaps? |
It's a limitation of Xerces. But I found a topic about this problem https://www.oxygenxml.com/forum/topic12812.html#p36904 and Oxygen fixes the problem. The idea is to not validate XML with DTD (DOCTYPE) if DOCTYPE doesn't define <!ELEMENT or doesn't define PUBLIC, SYSTEM path. I will try to follow this rule. I give you feedback if I can manage that. |
Fix #379 Signed-off-by: azerr <azerr@redhat.com>
Fix #379 Signed-off-by: azerr <azerr@redhat.com>
Fix #379 Signed-off-by: azerr <azerr@redhat.com>
Fix #379 Signed-off-by: azerr <azerr@redhat.com>
Fix #379 Signed-off-by: azerr <azerr@redhat.com>
Fix #379 Signed-off-by: azerr <azerr@redhat.com>
Fix #379 Signed-off-by: azerr <azerr@redhat.com>
Amazing work, thanks! |
Glad it works for you @zwaldowski .Many thanks for your feedback. |
My organization has documents like this:
I'm trying to bind these documents using
fileAssociations
, but lsp4xml stops trying to bind at theDOCTYPE
. It should continue looking forxsi:schemaLocation
and infileAssociations
when theDOCTYPE
lacks a DTD reference.The text was updated successfully, but these errors were encountered: