Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover markup response ignored the hover client capability #525

Closed
angelozerr opened this issue Jul 22, 2019 · 0 comments · Fixed by #527
Closed

Hover markup response ignored the hover client capability #525

angelozerr opened this issue Jul 22, 2019 · 0 comments · Fixed by #527
Assignees
@angelozerr
Labels
bug Something isn't working hover
Milestone
v0.8.0

Comments

@angelozerr
Copy link
Contributor

Today XML Schema, DTD returns a MARKDOWN kind although it should check that client has this capability
@angelozerr angelozerr added bug Something isn't working hover labels Jul 22, 2019
@angelozerr angelozerr added this to the v0.8.0 milestone Jul 22, 2019
@angelozerr angelozerr self-assigned this Jul 22, 2019
angelozerr added a commit that referenced this issue Jul 22, 2019
@angelozerr
Hover markup kind response doesn't take care of client capability
2a50ea9 
Fix #525

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Jul 22, 2019
Merged
@angelozerr angelozerr changed the title Hover markup kind response doesn't take care of client capability Hover markup kind response ignores the hover client capability Jul 22, 2019
angelozerr added a commit that referenced this issue Jul 22, 2019
@angelozerr
Hover markup kind response ignores the hover client capability
20c3819 
Fix #525

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr removed this from the v0.8.0 milestone Jul 22, 2019
angelozerr added a commit that referenced this issue Jul 22, 2019
@angelozerr
Hover markup kind response ignores the hover client capability
af58dc2 
Fix #525

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jul 22, 2019
@angelozerr
Hover markup kind response ignores the hover client capability
b2a37e6 
Fix #525

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jul 22, 2019
@angelozerr
Hover markup kind response ignores the hover client capability
f2a9319 
Fixes #525

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr added this to the v0.8.0 milestone Jul 22, 2019
angelozerr added a commit that referenced this issue Jul 22, 2019
@angelozerr
Hover markup kind response ignores the hover client capability
abc006a 
Fixes #525

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr changed the title Hover markup kind response ignores the hover client capability Hover markup response ignored the hover client capability Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working hover
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Hover markup kind response ignores the hover client capability eclipse-lemminx/lemminx
1 participant
@angelozerr