Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache completion based on XML Schema/DTD #547

Closed
angelozerr opened this issue Jul 25, 2019 · 0 comments · Fixed by #548
Closed

Cache completion based on XML Schema/DTD #547

angelozerr opened this issue Jul 25, 2019 · 0 comments · Fixed by #548
Assignees
Labels
bug Something isn't working completion This issue or enhancement is related to completion support DTD hover performance This issue or enhancement is related to performance concerns XSD
Milestone

Comments

@angelozerr
Copy link
Contributor

When completion based on XML Schema/DTD is done and XML Schema/DTD comes from the file system:

  • the DTD/Schema URI use file system
  • the DTD/Schema URI use http but cache is activated

The XMl Schema / DTD is every time parsed and loaded. For a big XML Schema / DTD, there are some trouble:

  • completion can be slow.
  • if it's too slow, completion returns nothing.

To fix this issue, we should cache the completion (the CMDocument) like we have done for http but we should track all files changed of the XML Schema (which can imported other XML Schema) to clean the cache when the XMl Schema / DTD is modified.

@angelozerr angelozerr self-assigned this Jul 25, 2019
@angelozerr angelozerr added bug Something isn't working completion This issue or enhancement is related to completion support DTD hover performance This issue or enhancement is related to performance concerns XSD labels Jul 25, 2019
angelozerr added a commit that referenced this issue Jul 25, 2019
Fixes #547

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jul 25, 2019
Fixes #547

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jul 25, 2019
Fixes #547

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr added this to the v0.9.0 milestone Jul 25, 2019
angelozerr added a commit that referenced this issue Jul 25, 2019
Fixes #547

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jul 25, 2019
Fixes #547

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Aug 17, 2019
Fixes #547

Signed-off-by: azerr <azerr@redhat.com>
@fbricon fbricon modified the milestones: v0.9.0, Sprint 171 Aug 20, 2019
angelozerr added a commit that referenced this issue Aug 20, 2019
Fixes #547

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Aug 20, 2019
Fixes #547

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completion This issue or enhancement is related to completion support DTD hover performance This issue or enhancement is related to performance concerns XSD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants