Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error range for SemicolonRequiredInReference #664

Closed
angelozerr opened this issue Apr 28, 2020 · 1 comment · Fixed by #745
Closed

Fix error range for SemicolonRequiredInReference #664

angelozerr opened this issue Apr 28, 2020 · 1 comment · Fixed by #745
Labels
bug Something isn't working DTD good first issue Good for newcomers validation
Milestone
0.12.0

Comments

@angelozerr
Copy link
Contributor

Given this XML file:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE article [
  <!ENTITY mdash "&#x2014;">
]>
<root>
  &mdash
</root>

&mdash should be ends with ; and Xerces report the error as SemicolonRequiredInReference. We should adjust error range to highlight &mdash
@angelozerr angelozerr added bug Something isn't working good first issue Good for newcomers validation DTD labels Apr 28, 2020
@fbricon
Copy link
Contributor

fbricon commented May 29, 2020

@datho7561 can you look at this one next please?

datho7561 added a commit to datho7561/lemminx that referenced this issue May 29, 2020
@datho7561
Fixed error range for SemicolonRequiredInReference
b83dfbc 
The error range now goes from the start of the ampersand to
the end of the entity name.

Fixes eclipse-lemminx#664

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue May 29, 2020
Merged
datho7561 added a commit to datho7561/lemminx that referenced this issue May 29, 2020
@datho7561
Fixed error range for SemicolonRequiredInReference
6ceb9c6 
The error range now goes from the start of the ampersand to
the end of the entity name.

Fixes eclipse-lemminx#664

Signed-off-by: David Thompson <davthomp@redhat.com>
@fbricon fbricon added this to the 0.12.0 milestone May 29, 2020
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 1, 2020
@datho7561
Fixed error range for SemicolonRequiredInReference
33b7457 
The error range now goes from the start of the ampersand to
the end of the entity name.

Fixes eclipse-lemminx#664

Signed-off-by: David Thompson <davthomp@redhat.com>
fbricon pushed a commit that referenced this issue Jun 1, 2020
@datho7561 @fbricon
Fixed error range for SemicolonRequiredInReference
3d2be14 
The error range now goes from the start of the ampersand to
the end of the entity name.

Fixes #664

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working DTD good first issue Good for newcomers validation
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Fixed error range for SemicolonRequiredInReference datho7561/lemminx
2 participants
@fbricon @angelozerr