Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range formatting inserts <null> when formatting inside DOCTYPE element #682

Closed
xorye opened this issue May 8, 2020 · 0 comments · Fixed by #764
Closed

Range formatting inserts <null> when formatting inside DOCTYPE element #682

xorye opened this issue May 8, 2020 · 0 comments · Fixed by #764
Assignees
@angelozerr
Labels
bug Something isn't working DTD formatting This issue or enhancement is related to formatting support
Milestone
0.12.0

Comments

@xorye
Copy link

xorye commented May 8, 2020

When range formatting content inside of <!DOCTYPE, the formatter replaces the content with <null>.

Example:

<?xml version='1.0' standalone='no'?>
<!DOCTYPE root-element [
    <!ENTITY local "LOCALLY DECLARED ENTITY">
]>

image

image
@fbricon fbricon added bug Something isn't working formatting This issue or enhancement is related to formatting support DTD labels May 19, 2020
@xorye xorye mentioned this issue May 25, 2020
Open
@fbricon fbricon added this to the 0.12.0 milestone Jun 3, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue Jun 4, 2020
@angelozerr
Range formatting inserts <null> when formatting inside DOCTYPE element
605bd0a 
Fixes eclipse-lemminx#682

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Jun 4, 2020
Merged
angelozerr added a commit to angelozerr/lemminx that referenced this issue Jun 5, 2020
@angelozerr
Range formatting inserts <null> when formatting inside DOCTYPE element
19539c4 
Fixes eclipse-lemminx#682

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Jun 5, 2020
@angelozerr
Range formatting inserts <null> when formatting inside DOCTYPE element
fdd7b59 
Fixes eclipse-lemminx#682

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Jun 5, 2020
@angelozerr
Range formatting inserts <null> when formatting inside DOCTYPE element
f711b24 
Fixes eclipse-lemminx#682

Signed-off-by: azerr <azerr@redhat.com>
@xorye xorye closed this as completed in #764 Jun 8, 2020
xorye pushed a commit that referenced this issue Jun 8, 2020
@angelozerr @xorye
Range formatting inserts <null> when formatting inside DOCTYPE element
3ffb1ff 
Fixes #682

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working DTD formatting This issue or enhancement is related to formatting support
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Range formatting inserts <null> when formatting inside DOCTYPE element angelozerr/lemminx
3 participants
@fbricon @angelozerr @xorye