Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic error range for MSG_SPACE_REQUIRED_BEFORE_ELEMENT_TYPE_IN_ELEMENTDECL #902

Closed
angelozerr opened this issue Oct 6, 2020 · 0 comments · Fixed by #915
Closed
Assignees
Labels
bug Something isn't working code action validation
Milestone

Comments

@angelozerr
Copy link
Contributor

Given this DTD:

<!ELEMENTelement-name (#PCDATA)>

The error range is

image

although it should just higlight !ELEMENT

Provide a code action which adds a space after !ELEMENT

Do the same thing for

  • <!ATTLISTelement-name attribute-name ID #REQUIRED>
  • <!ENTITYentity-name SYSTEM "entity-value">
@angelozerr angelozerr added bug Something isn't working validation code action labels Oct 6, 2020
@datho7561 datho7561 self-assigned this Oct 20, 2020
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 20, 2020
If a ELEMENT, ENTITY, or ATTLIST is missing after its declaration, i.e.:

```dtd
<!ENTITYnbsp
```

The declaration keyword is used as the error range. i.e.:

```dtd
<!|ENTITY|nbsp
```

Closes eclipse-lemminx#902

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 21, 2020
If a ELEMENT, ENTITY, or ATTLIST is missing after its declaration, i.e.:

```dtd
<!ENTITYnbsp
```

The declaration keyword is used as the error range. i.e.:

```dtd
<!|ENTITY|nbsp
```

Closes eclipse-lemminx#902

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 21, 2020
If a ELEMENT, ENTITY, or ATTLIST is missing after its declaration, i.e.:

```dtd
<!ENTITYnbsp
```

The declaration keyword is used as the error range. i.e.:

```dtd
<!|ENTITY|nbsp
```

Closes eclipse-lemminx#902

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 21, 2020
If a ELEMENT, ENTITY, or ATTLIST is missing a space after its declaration, i.e.:

```dtd
<!ENTITYnbsp
```

The declaration keyword is used as the error range. i.e.:

```dtd
<!|ENTITY|nbsp
```

Also adds a code action to add a space after these declarations.

Closes eclipse-lemminx#902

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 22, 2020
If a ELEMENT, ENTITY, or ATTLIST is missing a space after its declaration, i.e.:

```dtd
<!ENTITYnbsp
```

The declaration keyword is used as the error range. i.e.:

```dtd
<!|ENTITY|nbsp
```

Also adds a code action to add a space after these declarations.

Closes eclipse-lemminx#902

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 23, 2020
If a ELEMENT, ENTITY, or ATTLIST is missing a space after its declaration, i.e.:

```dtd
<!ENTITYnbsp
```

The declaration keyword is used as the error range. i.e.:

```dtd
<!|ENTITY|nbsp
```

Also adds a code action to add a space after these declarations.

Closes eclipse-lemminx#902

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr added this to the 0.14.0 milestone Oct 23, 2020
angelozerr pushed a commit that referenced this issue Oct 23, 2020
If a ELEMENT, ENTITY, or ATTLIST is missing a space after its declaration, i.e.:

```dtd
<!ENTITYnbsp
```

The declaration keyword is used as the error range. i.e.:

```dtd
<!|ENTITY|nbsp
```

Also adds a code action to add a space after these declarations.

Closes #902

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code action validation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants