Added request for 'canBindGrammar' for vscode-xml command

[AlexXuChen]

Added request for 'canBindGrammar' for vscode-xml 'Open Binding Wizard' command.

References: redhat-developer/vscode-xml/pull/544

Signed-off-by: Alexander Chen alchen@redhat.com

[angelozerr]

To be consistent with binding grammar command please use custom command instead of adding new method to the xml language server and services

[AlexXuChen]

To be consistent with binding grammar command please use custom command instead of adding new method to the xml language server and services

Atm this is a custom command on the client side, where it uses the commands.executeCommand('setContext', 'canBindGrammar', result) (See the pr on vscode-xml). Is this what you're referring to?

[angelozerr]

No i mean to do like https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/extensions/contentmodel/commands/AssociateGrammarCommand.java

[AlexXuChen]

This isn't a command itself though, it is the check to see if the command defined on the vscode-xml side should be exposed or not.

For example, if we have an xml document:

<tag
   attr1=""
   attr2=""/>

then the command I made in vscode-xml should be exposed on the command palette (XML: Bind to grammar/schema)

If instead we have:

<tag xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 xsi:noNamespaceSchemaLocation="foo.xsd"
   attr1=""
   attr2=""/>

Then you shouldn't be able to find the command on the command palette.

The command itself is defined and registered in vscode-xml, the check is the communication between the client and server to see if the command should run at all.

So the command to associate grammar, https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/extensions/contentmodel/commands/AssociateGrammarCommand.java, is the command that will be run if the client exposes the "Bind to grammar/schema file", which I believe means I don't need a new command on the lemminx side.

Please correct me if I've misunderstood.

[AlexXuChen]

Has grammar? -> yes -> Dont expose "Bind to ..."
I
-> no -> Expose "Bind to ..." -> Call binding wizard (xml.open.binding.wizard) -> Bind grammar (xml.command.bind.grammar)

[AlexXuChen]

Just to confirm, I understand your ask, which is to keep this out of XMLLanguageServer.java, and do something similar to the command, however when looking through the command and plugin, I was unable to find the entry point to the server.

[angelozerr]

Yes i understand that. In the vscode xml you create a new request type but please dont do that since now we have the capability to consume command line we did with xml.associate.grammar.insert. please consume the new xml.associat.grammar.canBinding command on vscode-xml side registered on lemminx side

[angelozerr]

Yes i confirm that.

To understand more command
Please read https://github.com/eclipse/lemminx/blob/master/docs/LemMinX-Extensions.md#command-service

[angelozerr]

Please write test for

• CheckBoundGrammarCommand (see https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/extensions/contentmodel/commands/AssociateGrammarCommandTest.java for sample of command test)
• AssociateGrammarCommand with the case of XML document which is already bound. Add this test in https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/extensions/contentmodel/commands/AssociateGrammarCommandTest.java

[AlexXuChen]

Writing tests in progress

[angelozerr]

Great job @AlexXuChen !